Remove deprecated methods & properties #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`state` and `receivedTrigger` have been marked as deprecated since June 2022. Signed-off-by: Florian Hotze <[email protected]>
The core-provided private and shared cache are available since openHAB 3.4, and the default cache methods have been marked as deprecated since end of 2022. Signed-off-by: Florian Hotze <[email protected]>
`createTimerWithArgument` has been marked as deprecated since openHAB 3.4, and besides of that is not thread-safe. Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
florian-h05
added
enhancement
|
I want to make sure that those versions of the rule templates remain compatible with the version of the helper library that comes with the 3.4 add-on so I'll leave them as is. I agree, plenty of time has passed. There shouldn't be any OH 4 users trying to use these. |
Sounds reasonable 👍
And moving away from the deprecated methods was relatively easy and straighforward. I am getting rid of the deprecated stuff now because with #331 there already is a breaking change for the next release, so I can now bundle all breaking changes into one release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stateandreceivedTriggerevent object properties.createTimerWithArgument(users should usecreateTimerorsetTimeoutinstead,createTimerWithArgumentis not even thread-safe).All these have been marked as deprecated at least since openHAB 3.4, which was released end of 2022, which means users have had enough time to adjust their code.
@rkoshak FYI. I have checked openhab-rules-tools, only usage of deprecated methods I could find was in open_reminder.yaml and debounce.yaml. However both of these are only published for openHAB 3.x on the marketplace, therefore this should be fine.